Recording vehicle change is working

car/src/car/control/gpio/recording_vehicle_decorator.py

@@ -39,8 +39,10 @@ class VehicleRecordingDecorator:
         return self._recording
 
     @record.setter
-    def record(self, value):
-        self._recording = True
+    def record(self, value: bool):
+        if not value:
+            self._records = []
+        self._recording = value
 
     @property
     def throttle(self):
@@ -49,7 +51,8 @@ class VehicleRecordingDecorator:
     @throttle.setter
     def throttle(self, value):
         if self._recording:
-            self._records.append(('t', value, str(datetime.datetime.now())))
+            self._records.append(
+                't,' + str(value) + ',' + datetime.datetime.now().isoformat(sep=' ', timespec='seconds'))
         self._vehicle.throttle = value
 
     @property
@@ -59,7 +62,8 @@ class VehicleRecordingDecorator:
     @steering.setter
     def steering(self, value):
         if self._recording:
-            self._records.append(('s', value, str(datetime.datetime.now())))
+            self._records.append(
+                's,' + str(value) + ',' + datetime.datetime.now().isoformat(sep=' ', timespec='seconds'))
         self._vehicle.steering = value
 
     @property

car/src/car/tracking/lidar_servicer.py

@@ -43,7 +43,16 @@ class LidarServicer(PersonTrackingServicer):
         return empty.Empty()
 
     def record(self, request, context):
-        self._lidar.record = True
+        # TODO: Fix this to not require 
+        if request.value:
+            self.cache.start_cache()
+        else:
+            self.cache.stop_scanning()
+        self._lidar.record = request.value
+        return empty.Empty()
+
+    def save_lidar(self, request, context):
+        self._lidar.save_data(request.file)
         return empty.Empty()
 
     def onGroupsChanged(self, message):